search

haskell-infra / www.haskell.org

www.haskell.org site source
http://haskell.org
BSD 3-Clause "New" or "Revised" License
109 stars 93 forks source link

Fix styling of links #271

Closed alt-romes closed 1 year ago

alt-romes commented 1 year ago

In trying to improve the appearence of the Haskell main webpage a little bit, I've

  1. Removed the underline of links that appear
    • inside buttons
    • in the navbar
  2. Changed the dotted underline to a solid underline

Screenshots:

Old:

Screenshot 2023-06-27 at 13 59 32 Screenshot 2023-06-27 at 13 59 42 Screenshot 2023-06-27 at 13 59 49

New:

Screenshot 2023-06-27 at 11 07 50 Screenshot 2023-06-27 at 11 07 40 Screenshot 2023-06-27 at 11 07 34

I suppose the dotted vs solid underline decision is more contentious, so I've added it as a separate commit we can also just drop.

Thanks!

tomjaguarpaw commented 1 year ago

I think we should also drop the underline entirely on the sponsor names and the video titles. They don't seems to serve any purpose to me and I think solid underline looks much worse there.

TikhonJelvis commented 1 year ago

We generally need something more than just color to indicate links, both for accessibility reasons and because we use purple all over the place. The video titles seem sufficiently clear based on context so we could drop the underline there, but I'm not sure about the sponsor names.

tomjaguarpaw commented 1 year ago

Ah yes, I was thinking the whole sponsor rectangle was a link, but it's only the logo and name. Well, I think the full underline is far too obtrusive in the sponsor name link, but I'm not a graphic designer, so weight my opinion accordingly.

TikhonJelvis commented 1 year ago

Yeah, I'm not sure either, but seems fine to keep it underlined for now.

@alt-romes Do you think getting rid of the underline for the videos makes sense? I'd lean in that direction, but I'm not 100% on it either :/. If it makes sense, could you add it in this PR?

alt-romes commented 1 year ago

Yes, done:

Screenshot 2023-06-27 at 16 17 59
alt-romes commented 1 year ago

but I'm not a graphic designer

I wonder if it would make sense for the @haskellfoundation to invest in re-designing some parts of the website/branding. I was recently pleasantly surprised to see the mature/polished look of ocaml's website and learn/docs pages.

This not to say that the haskell website is immature, just that there's space to improve and OCaml seems to be a good reference.

(which prompted me to look for low hanging style fruit in the haskell website)

tomjaguarpaw commented 1 year ago

Looks good to me. @TikhonJelvis I'll let you carry this over the line.

TikhonJelvis commented 1 year ago

Sweet. Thanks for the improvements @alt-romes!