search

haskell-mafia / mafia

Provides protection against cabal swindling, robbing, injuring or sabotaging people with chopsticks.
http://haskell-mafia.github.io/mafia/
BSD 3-Clause "New" or "Revised" License
135 stars 19 forks source link

Possible fix for Mac OS X linker issues integrated into mafia? #221

Closed justanotherdot closed 6 years ago

justanotherdot commented 6 years ago

Ran into this awhile back and @jystic mentioned might be worth us integrating directly into mafia itself.

erikd commented 6 years ago

I'm on Linux so :see_no_evil: :hear_no_evil: :speak_no_evil:.

However if you or someone else can integrate this neatly, then I'm all for it.

justanotherdot commented 6 years ago

I'm on Linux so 🙈 🙉 🙊.

Same here, but I do have to use a Mac for work. I haven't yet run into it myself as of yet on High Sierra so I've nothing yet to reproduce to test again if I gave a fix a go.

nhibberd commented 6 years ago

https://phabricator.haskell.org/D4714

justanotherdot commented 6 years ago

https://phabricator.haskell.org/D4714

@nhibberd does that actually fix it? I haven't tried yet. @markhibberd mentioned the boris-http module would be one place to test, but I couldn't replicate as I needed to get postgres installed to go further and lost focus.

erikd commented 6 years ago

@justanotherdot That fix works for the Cardano SL code base that was running into that problem.

justanotherdot commented 6 years ago

Nice 👌

erikd commented 6 years ago

It will be in 8.6 unless you roll your own earlier GHC with that fix backported.

justanotherdot commented 6 years ago

Should mafia be version aware and use this prior to 8.6?