search

haskell-mafia / mafia

Provides protection against cabal swindling, robbing, injuring or sabotaging people with chopsticks.
http://haskell-mafia.github.io/mafia/
BSD 3-Clause "New" or "Revised" License
135 stars 19 forks source link

Bump version bounds to give a build plan on GHC 8.4 #238

Closed tmcgilchrist closed 6 years ago

tmcgilchrist commented 6 years ago

Fixup the build failures from https://github.com/haskell-mafia/mafia/pull/220

cc @gwils

gwils commented 6 years ago

In travis, GHC 8.4 will be happier with cabal 2.2, but if it works anyway then there's probably no need to change it.

tmcgilchrist commented 6 years ago

Working on supporting Cabal 2.2 and above.

Were there any particular errors or problems you found with 2.0 and GHC 8.4?

gwils commented 6 years ago

Nope, but this fails for me locally on GHC 8.0.2

src/Mafia/Process.hs:199:5: error:
    Not in scope: data constructor ‘ProcessInternals.OpenExtHandle’
    Perhaps you meant one of these:
      ‘ProcessInternals.OpenHandle’ (imported from System.Process.Internals),
      ‘ProcessInternals.UseHandle’ (imported from System.Process.Internals),
      ‘ProcessInternals.ClosedHandle’ (imported from System.Process.Internals)
    Module ‘System.Process.Internals’ does not export ‘OpenExtHandle’.

src/Mafia/Process.hs:481:7: error:
    Not in scope: ‘Process.use_process_jobs’
    Module ‘System.Process’ does not export ‘use_process_jobs’.
tmcgilchrist commented 6 years ago

The lower bounds on process are wrong, both those things came in with process 1.5