search

haskell-nix / hnix-store

Haskell implementation of the Nix store
Apache License 2.0
87 stars 23 forks source link

Test failure on the macOS GHC 8.8 run, no /proc #109

Closed layus closed 3 years ago

layus commented 3 years ago 
  streamManyFilesToNar:   ls: cannot access '/proc/3496/fd': No such file or directory
FAIL (0.74s)

Example: https://github.com/haskell-nix/hnix/pull/810/checks?check_run_id=1665897143

Anton-Latukha commented 3 years ago

I opened #114 to track it.

sorki commented 3 years ago

Test is using this to check file descriptor counts before and after NAR streaming - https://github.com/haskell-nix/hnix-store/blob/master/hnix-store-core/tests/NarFormat.hs#L366-L372

No /proc in CI VMs?

Anton-Latukha commented 3 years ago

I opened #108 to track it.

Regarding the nix-store not present - I checked - nix and nix-store are in the path during the build.

layus commented 3 years ago

Oh, macos has no /proc. This was a real surprise. See https://superuser.com/questions/631693/where-is-the-proc-folder-on-mac-os-x

I am not at all interested in striving to support macos. But in this case I guess we can just disable that test on that platform until someone fixes it.

marsam commented 3 years ago

Hi, are there any plans to cut a new release soon? without this patch hnix-store-core is broken on nix darwin.

Anton-Latukha commented 3 years ago

Actually stumbled on the comment by doing the release currently, but stopped, since remote is also broken for darwin: https://github.com/haskell-nix/hnix-store/pull/114/checks?check_run_id=2097396100, so came here to revive the report in the sope of the Remote.

Remote not macOS is some deal-breaker, since the release being made just to give macOS support.

I restarted the build, but it would reproducibly reappear, since remote uses linux-namespaces or something like that.

Project get release both at the same time.

But since one does not have macOS support the CI can not do the check.

So the temporary back'n' forth CI changes needed just to release the project. If we release just core, it breaks the whole version cadence.

Anton-Latukha commented 3 years ago

Well, lets quickly make a Core release then.

Well, actually, lets release both, as remote never claimed macOS support.

Anton-Latukha commented 3 years ago

@marsam, releases are out to Hackage.

But with the default -fprof flag 8) This first time releasing projects in the pressing time, only Hackage notified me there is profiling enabled by default 8).

Next would upload the docs and stuff. But the most important for Nixpkgs is done.

Anton-Latukha commented 3 years ago

@marsam: Releases done.

There are thing to clean-up afterwards, but the main thing for Nixpkgs is done.

marsam commented 3 years ago

Cool, thank you!

Anton-Latukha commented 3 years ago

Well, the strangeness of my previous actions here - is that GitHub was acting really weird, write actions were completely blocked, but were appearing 10 minutes after.