haskell-nix / hnix-store

Haskell implementation of the Nix store
Apache License 2.0
86 stars 23 forks source link

remote: add AddToStoreNar operation #277

Closed squalus closed 10 months ago

squalus commented 10 months ago

Some open items:

Closes #265

sorki commented 10 months ago

Very nice (especially the framing!) and sorry for the conflicts! Wanted to merge earlier but didn't get to it sooner.

The CheckSignatures is also in core (I've realized it is actually CheckSignatures as well only couple days ago) - but don't worry about it, I'll deal with it.

You're right about opSuccess, most ops simply return True and indicate errors via logger so it seemed appropriate to just use () but this one makes it weird, I agree about the newtype.

No idea about the chunk size tbh.

squalus commented 10 months ago
sorki commented 10 months ago

Nicely done, thank you!

sorki commented 9 months ago

Btw I'm pretty much done with most large-scale changes/refactors so things should settle down now, feel free to tackle what you see fit.