Closed squalus closed 10 months ago
Very nice (especially the framing!) and sorry for the conflicts! Wanted to merge earlier but didn't get to it sooner.
The CheckSignatures
is also in core (I've realized it is actually Check
Signatures as well only couple days ago) - but don't worry about it, I'll deal with it.
You're right about opSuccess
, most ops simply return True
and indicate errors via logger so it seemed appropriate to just use ()
but this one makes it weird, I agree about the newtype.
No idea about the chunk size tbh.
()
reply type with a new SuccessCodeReply
typeNoReply
type for this caseNicely done, thank you!
Btw I'm pretty much done with most large-scale changes/refactors so things should settle down now, feel free to tackle what you see fit.
Some open items:
()
is already taken byopSuccess
which reads a boolean. MaybeopSuccess
should use a new reply type, and this one should use()
RemoteStoreError_Fixme
usagesSampleNar
Closes #265