Please, form a new release

haskell-nix / hnix-store

Haskell implementation of the Nix store

Apache License 2.0

87 stars 23 forks source link

Please, form a new release #85

Closed Anton-Latukha closed 3 years ago

Anton-Latukha commented 3 years ago

The fix release would allow to merge the https://github.com/haskell-nix/hnix/pull/554.

Anton-Latukha commented 3 years ago

Last 2 releases on Hackage were broken: https://matrix.hackage.haskell.org/#/package/hnix-store-core https://matrix.hackage.haskell.org/#/package/hnix-store-remote

Remote fails because of wrong bounds on the Hackage HNix-Core: allows but does not support base16-bytestring >= 1.

Recently I migrated Core to the base16-bytestring >= 1 #84.

Please make a Core release, then the Remote would build.

Thank you.

Anton-Latukha commented 3 years ago

Remote also in the Nixpkgs marked broken. AFAIK it was marked as such at least quite often if not continuously for a long periods of time.

Now project has some basic CI testing. The master of Core and Remote are fixed, and their release should fix it.

After that - there would be a sense in marking Remote as normal in Nixpkgs.

sorki commented 3 years ago

Drafted new one at #103

Do we want #93 included as well?

Anton-Latukha commented 3 years ago

Do we want #93 included as well?

Nah. That refactor is a bore, it is just some steps to be in-between closer to the full one.

Anton-Latukha commented 3 years ago

:partying_face: https://hackage.haskell.org/package/hnix-store-core

sorki commented 3 years ago

I think I've found a Hackage bug in the process as I've initially uploaded master just to realize I wanted a commit before to not have next changelog entries there but subsequent candidate uploads nor final --publish didn't correct it.

Anton-Latukha commented 3 years ago

Maybe publish a new minor point release?

@sorki Please, notify us when the release would resolve.

sorki commented 3 years ago

I think it's fine, there's just little extra content in https://hackage.haskell.org/package/hnix-store-core-0.4.0.0/changelog

Not worth another round.

Anton-Latukha commented 3 years ago

Oh - do not worry. Happens all the time. I made the same mistake recently :laughing:

I see the HNix-Store-Core 0.4 already compiles: https://github.com/haskell-nix/hnix/pull/785/checks?check_run_id=1628117901, cheers.

Sorry if bothered you in any way in the holidays before NY.

Anton-Latukha commented 3 years ago

Looked into Nixpkgs.

Core seems to be in the normal state there.
Made dontCheck self.cryptohash-sha512, since I know that the upstream is stale and its test suite is incompatible with base16-bytestring, while our patched version is compatible - so aligned that in the Nixpkgs.
Took Remote away from the broken list, and because its test suite afaik requires network access rights, and is not enabled by default - added dontCheck self.hnix-store-remote.

So, probably Nixpkgs is dealt with.

Pety afair said would merge even on/around New Years.