search

haskell-nix / hnix

A Haskell re-implementation of the Nix expression language
https://hackage.haskell.org/package/hnix
BSD 3-Clause "New" or "Revised" License
756 stars 115 forks source link

Please, deprecate `AttrSet` #1007

Open Anton-Latukha opened 2 years ago

Anton-Latukha commented 2 years ago

In 2 years of work on the project - AttrSet alias that was around not grown on me.

I still prefer seeing HashMap VarName <thing at hand> then implicit AttrSet <set at hand>. I think the contributors & especially newcomers would appreciate not complicating things, HashMap VarName <thing at hand> is a nice type signature & it is easy to reason about it.