search

haskell-nix / hnix

A Haskell re-implementation of the Nix expression language
https://hackage.haskell.org/package/hnix
BSD 3-Clause "New" or "Revised" License
756 stars 115 forks source link

fix getFreeVars and add test #1011

Closed Radvendii closed 2 years ago

Radvendii commented 2 years ago

the treatment of variable bindings was of so e.g. {x}: x was said to have x as a free variable. This seemed to just be a mistake to me, so I fixed it and added a test for that and similar cases.

Anton-Latukha commented 2 years ago

I remember some talk about {x}: x - but do not remember what the theme was. But your fix makes sense & I love things that make sense.

Anton-Latukha commented 2 years ago

CI is rough currently.

I navigate on Nixpkgs pinned build.

Also tested it locally.