search

haskell-nix / hnix

A Haskell re-implementation of the Nix expression language
https://hackage.haskell.org/package/hnix
BSD 3-Clause "New" or "Revised" License
756 stars 115 forks source link

Compile on GHC 9.4.3 #1081

Closed alex-mckenna closed 1 year ago

alex-mckenna commented 1 year ago

This PR bumps dependency bounds and makes small fixes to allow hnix to build with GHC 9.4.3.

alex-mckenna commented 1 year ago

Trying it out locally, I can also build with no problems on GHC 9.2.4 after this patch.

I see neither versions are included in CI. Would you like me to add 9.2 and 9.4 to the GitHub CI? I don't know if testing double the number of versions of GHC that are tested currently would make CI too slow for comfort or not.

sjakobi commented 1 year ago

Yes, CI with 9.2 and 9.4 would be great to have. If adding both causes problems, my preference would be to add CI with just 9.4.

alex-mckenna commented 1 year ago

I've added the GHC versions to CI, I wasn't sure from looking if the other workflows needed any changes.

In the process I noticed that although I didn't bump the version for time, everything built without it (even though time is a boot library). This seemed... odd, so I also bumped time to the bounds the release notes for 9.4.3 suggest.

sjakobi commented 1 year ago

Thanks a lot, @alex-mckenna! :)