search

haskell-numerics / hmatrix

Linear algebra and numerical computation
381 stars 104 forks source link

Fix segfault in zgesdd_ #325

Closed HuwCampbell closed 4 years ago

HuwCampbell commented 4 years ago

Fixes #324.

I changed the variable name q to mn to match the documentation in the source; changed the broken line to not assume a recent lapack version and turned it back on; and made the more pessimistic call not assuming mx >> mn (how is that computable anyway?).

This fixes the test suite for me on OSX with larger sized matrices (tested 100, which would reliably segfault for me). It would be good if someone could do some tests on Linux with increased sizes as well.

idontgetoutmuch commented 4 years ago

Fixes #324.

I changed the variable name q to mn to match the documentation in the source; changed the broken line to not assume a recent lapack version and turned it back on; and made the more pessimistic call not assuming mx >> mn (how is that computable anyway?).

This fixes the test suite for me on OSX with larger sized matrices (tested 100, which would reliably segfault for me). It would be good if someone could do some tests on Linux with increased sizes as well.

The tests pass on CI which is ubuntu.