search

haskell-opengl / OpenGL

Haskell bindings to OpenGL
http://www.haskell.org/haskellwiki/OpenGL
BSD 3-Clause "New" or "Revised" License
147 stars 26 forks source link

Fix typo: SeperateAttribs -> SeparateAttribs #77

Closed kranich closed 9 years ago

kranich commented 9 years ago

I submitted a pull request #76 to that end.

svenpanne commented 9 years ago

To make the transition a bit smoother and avoid a major version bump, can we please keep the old SeperateAttribs constructor, too? Just add the correctly spelled constructor and a deprecation pragma like:

{-# DEPRECATED SeperateAttribs "Use 'SeparateAttribs' instead." #-}

After a few releases I'll remove the old constructor and bump the major version then. GLUT had a similar issue, BTW: https://github.com/haskell-opengl/GLUT/commit/3e4baea50971af2bd21febbc8e70356113aeecb8

kranich commented 9 years ago

OK, just implemented your suggestions.

kranich commented 9 years ago

Build passed. You can merge pull request #76.

svenpanne commented 9 years ago

Done. Thanks for the fix!