search

haskell-party / feed

Haskell package for handling various feed (RSS) formats.
Other
30 stars 22 forks source link

Update parseFeedFromFile to return a Maybe Feed for consistency #33

Closed jkeuhlen closed 5 years ago

jkeuhlen commented 5 years ago

This leaves all of the IO errors that could be thrown alone, but makes any parser failures into a Nothing as discussed in https://github.com/bergmark/feed/issues/32

jkeuhlen commented 5 years ago

@bergmark Any idea what I did wrong here? I'm not really familiar with travis CI. I also found a few other inconsistencies (all minor things) that I wanted to help fix so I want to make sure I'm submitting PRs correctly.

bergmark commented 5 years ago

Hmm strange, i sent a message via e-mail reply but it didn't turn up here! Travis may have done some changes that break the current build script, we may need to update to https://github.com/haskell-CI/haskell-ci. I'll take a look

bergmark commented 5 years ago

The issue may have been that we were using cabal-install HEAD for travis. Makes sense that it would break eventually... I merged that fix into this branch.

bergmark commented 5 years ago

👍 i'll make a release now.