search

haskell-servant / servant-auth

160 stars 73 forks source link

Get rid of crypto-api #110

Closed domenkozar closed 5 years ago

domenkozar commented 6 years ago

memory is already a dependency due to jose, etc.

scope:

$ git grep -i BS64
src/Servant/Auth/Server/Internal/Cookie.hs:import qualified Data.ByteString.Base64   as BS64
src/Servant/Auth/Server/Internal/Cookie.hs:      xsrfValue <- BS64.encode <$> getEntropy 32

$ git grep Crypto.Util
src/Servant/Auth/Server/Internal/Cookie.hs:import           Crypto.Util              (constTimeEq)
src/Servant/Auth/Server/Internal/JWT.hs:import           Crypto.Util          (constTimeEq)

https://hackage.haskell.org/package/memory-0.14.16/docs/Data-Memory-PtrMethods.html#v:memConstEqual

domenkozar commented 6 years ago

@phadej points out that servant-server and wai-extra depen on base64-bytestring anyway.