search

haskell-servant / servant-elm

Automatically derive Elm functions to query servant webservices
BSD 3-Clause "New" or "Revised" License
164 stars 48 forks source link

Temporary fix for Header. #31

Closed hadronized closed 6 years ago

hadronized commented 6 years ago

Fix for Header and Maybe in the generated code.

See https://github.com/haskell-servant/servant/pull/843 for further details.

The stack.yaml file was altered so that I can successfully have it compiled with the latest servant and servant-foreign.

hadronized commented 6 years ago

Any news on that pals? :)

hadronized commented 6 years ago

Sure, I didn’t see those. I’ll fix them. Maybe @alpmestan might know when it’ll get released?

alpmestan commented 6 years ago

Oh we can definitely merge several outstanding PRs and ship a new release reasonably soon (upcoming weeks -- can't make it more precise, I've been a bit busy with another servant related thing that we might "ship" too at the same time).

alpmestan commented 6 years ago

I just merged the servant PR though.

hadronized commented 6 years ago

That should be okay now!

hadronized commented 6 years ago

Friendly ping.

hadronized commented 6 years ago

(I’ll also change that stack.yaml thing, since we might be able to use a nightly with the correct servant version now).

hadronized commented 6 years ago

It works with a proper stack.yaml. What should I do to clean it up completely, and have a new version of servant-elm released?

hadronized commented 6 years ago

Peeps? :)

mattjbray commented 6 years ago

Hi! Sorry for the long silence. I've just seen that Servant 0.13 has added Required and Optional modifiers for both Header and QueryParam, so I've updated this PR to support that. Thanks!

hadronized commented 6 years ago

Awesome, thanks!