search

haskell-servant / servant-elm

Automatically derive Elm functions to query servant webservices
BSD 3-Clause "New" or "Revised" License
164 stars 48 forks source link

use the "elmName" rather than "name" for query flags and param lists #42

Closed nicklawls closed 6 years ago

nicklawls commented 6 years ago

Looking at the servant docs here, it looks like the query flags and query parameter lists are being generated incorrectly. Although I did have to change the tests, so maybe this is the expected behavior and I'm missing something.

It's rendering "query_paramName=", which is the Elm variable name, as opposed to just "paramName=", which I think should be correct. Somewhat confusingly, the former is called name in the code while the latter is called elmName. Maybe that's where the mix up came from?

mattjbray commented 6 years ago

Tests pass locally, not sure what's up with travis. Thanks!