search

haskell-servant / servant-multipart

Support for file uploads in multipart/form-data for servant
https://hackage.haskell.org/package/servant-multipart
40 stars 37 forks source link

Support `servant-0.20`. #67

Closed ocharles closed 1 year ago

marinelli commented 1 year ago

We can do this https://github.com/marinelli/servant-multipart/commit/8e9e9ba9fe4dc13d5e96e58244b098a7d1c5bd1c to move forward with this PR.

Miezhiko commented 1 year ago

We can do this marinelli@8e9e9ba to move forward with this PR.

why there is no Pull Request with those changes?

marinelli commented 1 year ago

We can do this marinelli@8e9e9ba to move forward with this PR.

why there is no Pull Request with those changes?

I was waiting for @ocharles (the original author of this PR). I also had a look at this other PR https://github.com/haskell-servant/servant-multipart/pull/68, and given that the Servant.Multipart.Client module already uses TypeApplications, the simplest solution is to replace the pure occurrences with pure @[], eg: https://github.com/haskell-servant/servant-multipart/commit/a2bf235bd5ade12226088a0c8cd169ba65045dfe.