search

haskell-servant / servant-multipart

Support for file uploads in multipart/form-data for servant
https://hackage.haskell.org/package/servant-multipart
40 stars 37 forks source link

Upload files to memory #7

Closed ArktinenSieni closed 7 years ago

ArktinenSieni commented 7 years ago

How does progress look so far?

alpmestan commented 7 years ago

Pretty good! Just one thing that I would like to see (unless a good argument is made against that): do not use the options type as the "token" that decides what backend to use. I'd instead like to see something like type API = MultipartForm Mem (MultipartData Mem) :> ... (or same with Tmp to use temporary files) if you don't mind?

ArktinenSieni commented 7 years ago

Updated documentation with my possibly lacking understanding ^^'

ArktinenSieni commented 7 years ago

Added and edited documentation as requested. stack haddock built as intended.

alpmestan commented 7 years ago

Made a tiny comment, otherwise it's looking good!

alpmestan commented 7 years ago

Awesome. @phadej @ArktinenSieni if you guys need for this to ship ASAP, let me know. Or feel free to do the release yourself @phadej actually if you want =)

phadej commented 7 years ago

@alpmestan, no need to ship asap. Let's do it around the next servant major release - if nobody asks for it before specifically.