search

haskell-servant / servant

Servat is a Haskell DSL for describing, serving, querying, mocking, documenting web applications and more!
https://docs.servant.dev/
1.82k stars 412 forks source link

Fix AddSetCookies instance #1653

Closed tchoutri closed 1 year ago

tchoutri commented 1 year ago

Depends on https://github.com/haskell-servant/servant/pull/1652

Please review this carefully.

cc @hasufell @alpmestan @gdeest

tchoutri commented 1 year ago

@mgajda Your input is also valued. :)

endgame commented 1 year ago

I don't think this is right, because if you have this instance then it's impossible to change the types on either side of a :<|>, which doesn't seem like what you want?

tchoutri commented 1 year ago

@endgame great, thank you!