Clean build against nightly-2023-04-14

haskell-servant / servant

Main repository for the servant libraries — DSL for describing, serving, querying, mocking, documenting web applications and more!

https://docs.servant.dev/

1.8k stars 407 forks source link

Clean build against nightly-2023-04-14 #1675

Closed thomasjm closed 1 year ago

thomasjm commented 1 year ago

Similar to #1629, I'm opening this to see what the CI says.

ysangkok commented 1 year ago

@thomasjm The test suite has been run, but the failure doesn't seem similar to what you posted in #1629. I don't know much Nix any more, so not sure how to interpret the error here.

thomasjm commented 1 year ago

Okay, I added an hspec constraint for GHCJS and the tests are passing now: https://github.com/codedownio/servant/actions/runs/4726572557.

In summary this PR does the following:

Bump hspec bounds for everything except GHCJS, so the latest Stackage nightly works (GHC 9.4.4)
Modernize the CI workflow a little bit, including bumping GHC minor versions
Update the tested-with field in the cabal files

So I think this PR is ready to go and can supersede #1629

tchoutri commented 1 year ago

Alright, looks good! Unless anyone is objecting, I'll merge that later today

ysangkok commented 1 year ago

@tchoutri Looks good to me! Did something come up?

tchoutri commented 1 year ago

It did! Let's merge :)

thomasjm commented 1 year ago

Thanks all! I think we can close #1623 and #1629 now