search

haskell-servant / servant

Main repository for the servant libraries — DSL for describing, serving, querying, mocking, documenting web applications and more!
https://docs.servant.dev/
1.8k stars 407 forks source link

Add AddSetCookies instance for when the left tree is the same before and after the transformation #1698

Closed ohri-anurag closed 11 months ago

ohri-anurag commented 12 months ago

Adding code suggested by @mastarija on issue #1601

ohri-anurag commented 12 months ago

The CI fails here, but this is what I did on my machine:

  1. Modified this line in shell.nix: 
    -      buildInputs = [ ghc zlib python3 wget cabal-install postgresql openssl stack haskellPackages.hspec-discover ]
+      buildInputs = [ ghc zlib python3 wget cabal-install postgresql openssl stack haskellPackages.hspec-discover haskellPackages.doctest ]
  2. Ran this command: nix-shell nix/shell.nix --argstr compiler ghc865Binary
  3. Both cabal build all and cabal test all passed in the shell entered at step 2.
  4. I have also tested this with ghc 9.0.1, without any changes to shell.nix, it works.
ysangkok commented 11 months ago

Could you please rebase on master?

ysangkok commented 11 months ago

I don't think this rebase was done right, since some commits from the master branch are shown here.

ohri-anurag commented 11 months ago

Closed in favor of #1702