search

haskell-servant / servant

Main repository for the servant libraries — DSL for describing, serving, querying, mocking, documenting web applications and more!
https://docs.servant.dev/
1.8k stars 407 forks source link

pick up PR for named routes cookbook again #1726

Open MangoIV opened 4 months ago

MangoIV commented 4 months ago

This PR is supposed to pick up the great work started in https://github.com/haskell-servant/servant/pull/1542 and rebase on current changes as well as apply fixes suggested by the reviewers, potentially also addressing new change requests.

tchoutri commented 4 months ago

Thank you very much @MangoIV for this work! Reading the PR content, I feel like we ought to merge the NamedRoutes and Generics cookbooks together, under the NamedRoutes name.

MangoIV commented 4 months ago

that's a good idea, I will do that then :)

ysangkok commented 2 months ago

@MangoIV Are you still planning to do this?

MangoIV commented 2 months ago

I am. I think we’re blocked by servant-qc (release, I have updated it) but I don’t know, let me check; will get to it this week perhaps ;)

tchoutri commented 2 months ago

@MangoIV You may rebase your PR on top of master now, I've integrated servant-quickcheck in the monorepo.

MangoIV commented 2 months ago

Lovely thank you <3

tfc commented 2 months ago

Any news/blockers here regarding the merge? I also find this very valuable.

tchoutri commented 2 months ago

@tfc yes, Mango still has to merge the two cookbooks. :)

MangoIV commented 1 month ago

I have basically dropped the entire generic cookbook in favour of named routes, afaict I have transported all the information that didn't already occur in named routes but I would appreciate a thorough review to confirm.

MangoIV commented 1 month ago

@ysangkok i still have a couple of failures sorry, I should mark it as draft again