search

haskell-servant / servant

Servat is a Haskell DSL for describing, serving, querying, mocking, documenting web applications and more!
https://docs.servant.dev/
1.82k stars 412 forks source link

allow filepath versions < 1.6, rebased #1742

Closed ysangkok closed 3 months ago

ysangkok commented 5 months ago

Rebased version of #1724

ysangkok commented 5 months ago

Rebased as requested @tchoutri

ysangkok commented 5 months ago

Doesn't seem to actually work right now:

 % cabal build -c 'filepath >= 1.5' all
Resolving dependencies...
Error: cabal: Could not resolve dependencies:
[__0] trying: cookbook-basic-auth-0.1 (user goal)
[__1] trying: base-4.19.1.0/installed-eafb (dependency of cookbook-basic-auth)
[__2] trying: cookbook-openapi3-2.2 (user goal)
[__3] trying: servant-swagger-ui-0.3.5.5.0.0 (dependency of cookbook-openapi3)
[__4] trying: file-embed-lzma-0.0.1 (dependency of servant-swagger-ui)
[__5] next goal: filepath (dependency of file-embed-lzma)
[__5] rejecting: filepath-1.5.2.0 (conflict: file-embed-lzma =>
filepath>=1.1.4.1 && <1.5)
ysangkok commented 5 months ago

I don't think phadej will bump this until GHC 9.10 is out with filepath-1.5. Since this is boot library:

tchoutri commented 5 months ago

Ok we can wait for GHC 9.10 to be released. :)

tchoutri commented 4 months ago

@ysangkok I believe the time has come.

ysangkok commented 4 months ago

But file-embed-lzma hasn't been revised to allow GHC 9.10. So we're still blocked on the same issue.

ysangkok commented 3 months ago

Subsumed by #1765. Since filepath is a boot library, it makes more sense to just upgrade it along with GHC.