haskell-servant / servant

Main repository for the servant libraries — DSL for describing, serving, querying, mocking, documenting web applications and more!
https://docs.servant.dev/
1.8k stars 407 forks source link

Allow GHC 9.10 #1765

Closed ysangkok closed 2 weeks ago

ysangkok commented 1 month ago

This is related to #1753, but adds a bunch of allow-newers. There are so many dependencies of servant, that it will take a long time for all of them to catch up. To make sure GHC 9.10 keeps working in this repo, let's test with these allow-newers. Released packages won't have these bound overrides, of course.

ysangkok commented 1 month ago

I thought the failure was because of the colors, but it still fails locally with this snippet added to cabal.project:

if(impl(ghc >= 9.10.1))                                                             
  package servant                                                                   
    ghc-options: -fdiagnostics-color=never

See flag reference

ysangkok commented 4 weeks ago

This is the error in case the CI logs get deleted:

src/Servant/API/TypeLevel.hs:270: failure in expression `instance AtMostOneFragment FailAPI'
expected: ...
          ...Only one Fragment allowed per endpoint in api...
          ...
          ...In the instance declaration for...
 but got: <interactive>:6[39](https://github.com/haskell-servant/servant/actions/runs/9387799345/job/25851582146#step:10:40):10: error: [GHC-64725]
              • Only one Fragment allowed per endpoint in api ‘Fragment Bool
                                                               :> (Fragment Int :> Get '[JSON] NoContent)’.
          .................................................................................O^
              • In the instance declaration for ‘AtMostOneFragment FailAPI’