search

haskell-servant / servant

Servat is a Haskell DSL for describing, serving, querying, mocking, documenting web applications and more!
https://docs.servant.dev/
1.82k stars 412 forks source link

Exported Servant.Links.addQueryParam #1785

Open saurabhnanda opened 2 weeks ago

saurabhnanda commented 2 weeks ago

Closes #1232

tchoutri commented 2 weeks ago

@saurabhnanda Thanks a lot for this!

Could you please add a new changelog entry in the changelog.d file? Just like this one https://github.com/haskell-servant/servant/blob/master/changelog.d/issue-1780

saurabhnanda commented 2 weeks ago

@saurabhnanda Thanks a lot for this!

Could you please add a new changelog entry in the changelog.d file? Just like this one https://github.com/haskell-servant/servant/blob/master/changelog.d/issue-1780

@tchoutri I had created a branch from v0.20.2 and not master. I believe changelog.d has been introduced in master, along with some GHC-related deprecations? Are those intended? Because I am unable to build servant on Stack LTS-18.28 if I swtich to master branch.


       In the dependencies for servant-0.20.3:
         * base must match >=4.16.4.0 && <4.21, but base-4.14.3.0 is in the Stack configuration (latest matching version is 4.20.0.1).
         * bytestring must match >=0.11 && <0.13, but bytestring-0.10.12.0 is in the Stack configuration (latest matching version is 0.12.1.0).
       The above is/are needed since servant is a build target.
tchoutri commented 2 weeks ago

@saurabhnanda changelog-d has been around for quite some time, if I'm not mistaken.

Regarding the GHC deprecations: yes they are intended, see https://github.com/haskell-servant/servant/pull/1778.

You will need to update the Stack setup to use the LTS of 9.6.6.

saurabhnanda commented 2 weeks ago

@tchoutri added the changelog entry - hope it's fine.