Add fixites for current base

haskell-suite / haskell-src-exts

Manipulating Haskell source: abstract syntax, lexer, parser, and pretty-printer

Other

193 stars 94 forks source link

Add fixites for current base #400

Closed yairchu closed 6 years ago

yairchu commented 6 years ago

Added fixites found via grepping "infix" in the libraries/base folder of GHC repo (commit 4aa98f4a3cb0c965c4df19af2f1ccc2c5483c3a5), and ignored additional operators found under GHC module hierarchy.

Personally I'm missing <>'s fixity which mad hlint misfire until told what the fixity is.

ndmitchell commented 6 years ago

See https://github.com/haskell-suite/haskell-src-exts/pull/398/files which has a slightly different set of edits, but would conflict. Do you want to manually copy of the handful I found and you didn't, and delete the two I spotted are wrong, then I'll reject my PR.

ndmitchell commented 6 years ago

Concretely:

Remove :%
Move % from Prelude to Base
Add $> and <$ (only one of those was in my patch).

yairchu commented 6 years ago

Oops I didn't notice the existing PR, I'll abort this one instead..

ndmitchell commented 6 years ago

OK, I've copied the couple you got into my branch.