search

haskell-suite / haskell-src-exts

Manipulating Haskell source: abstract syntax, lexer, parser, and pretty-printer
Other
193 stars 95 forks source link

Add MonadFail instances to ParseMonad.hs #413

Closed vaibhavsagar closed 6 years ago

vaibhavsagar commented 6 years ago

This is needed for GHC 8.6.1.

vaibhavsagar commented 6 years ago

I see that this fails on GHC < 8.0. Do I use CPP, enable NoMonadFailDesugaring. or something else?

Edit: I've conditionally depended on fail since we already do this for semigroups.

hvr commented 6 years ago

btw, if the MonadFail instances are exposed via the API, this requires a minor version bump (i.e. it's a benign API addition)

vaibhavsagar commented 6 years ago

Thanks!