Closed dzhus closed 4 years ago
I don't think that test failure has anything to do with this change
The current version parses $e
and $(e)
.
Can you check that this PR parses both $$e
and $$(e)
? I believe is does not parse $$e
.
@AshleyYakeley you're right – it can now do $$id
as well, tests are updated too
CI failure is the same as before – not related to this change I think
Hi @dzhus what's the status on this? Any reason it has not been merged yet?
@pwm Probably because maintainer haven't got to do so yet. In the meantime hlint switched to GHC parser and the original problem no longer exists really :)
@dzhus Ah thanks, interesting. I'm pretty sure I've built hlint fairly recently from source and ran into this. Maybe they've switched to GHC parser after? Thanks anyway, will investigate.
Edit: Ah ok, needs I need 8.8 it seems: https://github.com/ndmitchell/hlint/blob/master/hlint.cabal#L76
@pwm actually, I may be wrong – I may have been testing it incorrectly
So I got annoyed by https://github.com/ndmitchell/hlint/issues/332 and took a stab at this too. This builds upon #410, using new constructors to parse
$$(
s and[||
s. I added some minimal tests too. This fixes #278.