search

haskell-suite / haskell-src-exts

Manipulating Haskell source: abstract syntax, lexer, parser, and pretty-printer
Other
193 stars 94 forks source link

test suite failure, probably due to a pretty printer dependency update #448

Open DanBurton opened 4 years ago

DanBurton commented 4 years ago 
Test suite failure for package haskell-src-exts-1.22.0
    test:  exited with: ExitFailure 1
Full log available at /var/stackage/work/unpack-dir/.stack-work/logs/haskell-src-exts-1.22.0-test.log

    Tests
      Parser tests
        OverloadedLabels:              OK (0.08s)
        RecordInfixSelector:           OK
        TabWhitespace:                 OK
        CxtWhitespace:                 OK (0.01s)
        CApiFFI:                       OK
        Rules:                         OK (0.01s)
        QuasiQuoteOld:                 OK
        GadtRecordFields:              OK
        Completesig03A:                OK
        LanguagePragma:                OK
        TemplateHaskellQuotedNames:    OK
        DerivingParen:                 OK
        THTSplices:                    OK
        GadtStrictness:                FAIL
          Files 'tests/examples/GadtStrictness.hs.parser.golden' and 'tests/examples/GadtStrictness.hs.parser.out' differ
        EqualityConstraints2:          OK
        BadStringLineBreak:            OK
....
        ContextOrdering:               OK (0.01s)
        ExtraPrettyParentheses:        OK (0.02s)
        RoleAnnotations:               OK (0.02s)
        Ppr048:                        OK
        Directory:                     FAIL (0.28s)
          Files 'tests/examples/Directory.hs.parser.golden' and 'tests/examples/Directory.hs.parser.out' differ
        ClassContext:                  OK (0.02s)
        SCCPragmas:                    OK
        TrailingWhere:                 OK
        TrailingWhere2:                OK
...
        DataKinds:                     OK (0.05s)
        StarInType:                    OK
        QuasiQuoteToplevel:            OK
        Nounpack2:                     FAIL
          Files 'tests/examples/Nounpack2.hs.parser.golden' and 'tests/examples/Nounpack2.hs.parser.out' differ
        ExtraEndBrace:                 OK
        IndentedTopLevelWhere:         OK
...
        FixityTests:                   OK (0.02s)
        DsStrictData:                  FAIL (0.03s)
          Files 'tests/examples/DsStrictData.hs.parser.golden' and 'tests/examples/DsStrictData.hs.parser.out' differ
        T13050:                        OK (0.02s)
        TySplice3:                     OK
...
        QuasiQuoteUnit:                OK
        AmbiguousFixities:             FAIL
          Files 'tests/examples/AmbiguousFixities.hs.parser.golden' and 'tests/examples/AmbiguousFixities.hs.parser.out' differ
        CStyleLinePragmas:             OK
        Lib:                           OK (0.02s)
...

Was seen on:

felixonmars commented 4 years ago

4 out of the 5 test failures seems to be pretty-show not willing to prettify the result: https://github.com/yav/pretty-show/issues/45

The other one seems to be an easy fix:

--- /build/haskell-src-exts/src/haskell-src-exts-1.21.1/tests/examples/AmbiguousFixities.hs.parser.golden        2020-02-22 10:31:04.000000000 +0100
+++ /build/haskell-src-exts/src/haskell-src-exts-1.21.1/tests/examples/AmbiguousFixities.hs.parser.out   2020-02-22 10:34:01.452563494 +0100
@@ -1 +1 @@
-ParseFailed (SrcLoc "" (-1) (-1)) "Ambiguous infix expression"
+ParseFailed (SrcLoc "" -1 -1) "Ambiguous infix expression"