search

haskell-tls / hs-certificate

Certificate and Key Reader/Writer in haskell
60 stars 57 forks source link

Use asn1-encoding rather than asn1-data #25

Closed tomfitzhenry closed 10 years ago

tomfitzhenry commented 10 years ago

asn1-encoding has a bunch of fixes that asn1-data does not have (that you wrote! :)).

The fix that interests me is treating T61String as ISO-8859-1: https://github.com/vincenthz/hs-asn1/commit/4651774f64c92eb5fd06f3878d933a95b0f87396 .

As an example, here is a test case that works with asn1-encoding, but fails under asn1-data: https://gist.github.com/tomfitzhenry/8795259

vincenthz commented 10 years ago

asn1-data is deprecated now that tls 1.2 is out and using the modular certificate packages (x509-*)

vincenthz commented 10 years ago

oh and forgot to say, that certificate is deprecated too. It's not very hard to migrate between certificate and x509. Let me know if you run in any difficulty if you happen to do that.

tomfitzhenry commented 10 years ago

Ah, I wasn't aware certificate was deprecated. Upgrading to x509 resolved my issue. Thank you.

vincenthz commented 10 years ago

Great. I've deprecated the package on hackage now.