search

haskell-unordered-containers / hashable

A class for types that can be converted to a hash value
BSD 3-Clause "New" or "Revised" License
102 stars 85 forks source link

added os-string flag to cabal file #290

Closed BebeSparkelSparkel closed 5 months ago

BebeSparkelSparkel commented 7 months ago

Allows using filepath version >=1.5.0.0 and the new os-string package

amigalemming commented 7 months ago

For the PVP the os-string version range looks too loose. It should be <2.1.

BebeSparkelSparkel commented 7 months ago

@amigalemming fixed the version bound

phadej commented 6 months ago

@LaurentRDC it probably could, but then users of old filepath and new os-string (which is possible combination AFAICT) won't get an instance on the types in os-string (there will be two different OsStrings).

I'm undecided whether I want to allow that option (and as it is, this PR wont: if you want os-string you are forced to use new filepath, even on old GHCs), or whether dependency on os-string should be unconditional (and code to be written).

I'll decide when GHC-9.10 is closer to release, when it's forced.

Until then, indeed, things "seem" to work if you just relax bounds (e.g. with allow-newer), so I'm not in a hurry.

andreasabel commented 5 months ago

@phadej : Would it be possible to release this now (or some other fix of the problem)?

Evaluation of GHC 9.10 is hampered atm since 1000 projects depend on hashable. Getting these unstuck would expose GHC 9.10 to more testing which would help the GHC 9.10 release process.

hasufell commented 5 months ago

GHC 9.10 prerelease is out and I'm running into this in ghcup-metadata CI.