search

haskell-unordered-containers / unordered-containers

Efficient hashing-based container types
BSD 3-Clause "New" or "Revised" License
221 stars 97 forks source link

Explicit definitions for stimes, sconcat and mconcat #307

Open sjakobi opened 3 years ago

sjakobi commented 3 years ago

So far our Semigroup and Monoid instances define only (<>) and mempty. Explicit definitions of stimes, sconcat and mconcat might be able to improve on the defaults.

sjakobi commented 3 years ago

For stimes, we can probably simply use stimesIdempotentMonoid.

sjakobi commented 2 years ago

Since the performance implications of using unions to define mconcat are unclear due to #139, I've removed the low-hanging-fruit label.

Apologies for not realizing the connection to #139 earlier! :/