Tests: Increase variation in generated tree shapes

haskell-unordered-containers / unordered-containers

Efficient hashing-based container types

BSD 3-Clause "New" or "Revised" License

221 stars 97 forks source link

Tests: Increase variation in generated tree shapes #442

Closed sjakobi closed 2 years ago

sjakobi commented 2 years ago

Addresses #438.

TODO:

[x] Use the same Key type for HashSet and Strictness tests
[ ] Try producing Full nodes?!
[x] Check that any tests that use specific colliding keys still do the right thing.
[x] Improve shrinking for SmallSum (https://github.com/nick8325/quickcheck/issues/343)

sjakobi commented 2 years ago

[ ] Try producing Full nodes?!

I think this might be a bit tricky. I don't think we can achieve this by tweaking the Key generator. I think we'd have to tweak the [(Key,X)] inputs for the property tests, which are currently using the default Arbitrary [] instance.

sjakobi commented 2 years ago

[ ] Try producing Full nodes?!

I think this might be a bit tricky. I don't think we can achieve this by tweaking the Key generator. I think we'd have to tweak the [(Key,X)] inputs for the property tests, which are currently using the default Arbitrary [] instance.

I'll leave this for future work. Ideally we can solve this by removing the Full constructor (#399).

sjakobi commented 2 years ago

[ ] Try producing Full nodes?!

I think this might be a bit tricky. I don't think we can achieve this by tweaking the Key generator. I think we'd have to tweak the [(Key,X)] inputs for the property tests, which are currently using the default Arbitrary [] instance.

I'll leave this for future work. Ideally we can solve this by removing the Full constructor (#399).

Tracked in https://github.com/haskell-unordered-containers/unordered-containers/issues/445.