search

haskell-unordered-containers / unordered-containers

Efficient hashing-based container types
BSD 3-Clause "New" or "Revised" License
221 stars 97 forks source link

Redundant `Hashable` constraints on `intersection*` and `union*` #443

Closed sjakobi closed 1 year ago

sjakobi commented 2 years ago

These functions don't compute any hashes, so we could consider removing the redundant constraints.

treeowl commented 2 years ago

Yank them, as far as I'm concerned. Did the previous intersection implementation need that?

sjakobi commented 2 years ago

Did the previous intersection implementation need that?

Yeah. It was based on unsafeInsert, so it was re-computing hashes.