`Full` node handling is mostly untested

haskell-unordered-containers / unordered-containers

Efficient hashing-based container types

BSD 3-Clause "New" or "Revised" License

221 stars 97 forks source link

`Full` node handling is mostly untested #445

Open sjakobi opened 2 years ago

sjakobi commented 2 years ago

The problem is that to create a Full node, the hashes need to come in a very particular shape. For example, to create a Full root node, the hash data needs to cover all 32 (maxChildren) combinations for the lowest 5 (bitsPerSubkey) bits. I believe the current test input generators will very rarely produce such data if at all.

sjakobi commented 2 years ago

Ideally we can address this by completely removing the Full constructor (#399).