search

haskell-unordered-containers / unordered-containers

Efficient hashing-based container types
BSD 3-Clause "New" or "Revised" License
222 stars 97 forks source link

Future-proof against potential Prelude.foldl' #480

Closed Bodigrim closed 1 year ago

Bodigrim commented 1 year ago

See https://github.com/haskell/core-libraries-committee/issues/167

This is, of course, a bit speculative at the moment, but given that the change does not involve CPP, it should not hurt to merge it early to simplify further impact assessment.

Bodigrim commented 1 year ago

@sjakobi @treeowl could someone please trigger CI jobs?

treeowl commented 1 year ago

Yes, sorry.

Bodigrim commented 1 year ago

@treeowl thanks, CI is green. Does the patch look reasonable?

treeowl commented 1 year ago

Yes, I think so.

Bodigrim commented 6 months ago

@treeowl could you possibly make a release with this patch please? It would allow to build with GHC HEAD.

treeowl commented 6 months ago

Yes, I should be able to do that today.

Bodigrim commented 6 months ago

@treeowl just a gentle reminder.

treeowl commented 6 months ago

Oof... Time got away from me. I'll get to it shortly.

On Wed, Jan 3, 2024, 4:22 PM ˌbodʲɪˈɡrʲim @.***> wrote:

@treeowl https://github.com/treeowl just a gentle reminder.

— Reply to this email directly, view it on GitHub https://github.com/haskell-unordered-containers/unordered-containers/pull/480#issuecomment-1875989323, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOOF7M46X7PWPOGBVD47UTYMXDZRAVCNFSM6AAAAAAY2BO2ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVHE4DSMZSGM . You are receiving this because you were mentioned.Message ID: <haskell-unordered-containers/unordered-containers/pull/480/c1875989323@ github.com>

treeowl commented 5 months ago

@Bodigrim, I'm sorry that took so long. It's all on Hackage now.

Bodigrim commented 5 months ago

Thanks a lot @treeowl!