search

haskell-works / hw-kafka-client

Kafka client for Haskell, including auto-rebalancing consumers
MIT License
139 stars 50 forks source link

update-versions: update librdkafka to latest + niv update + ghc 8107 #191

Open Gau-thier opened 2 years ago

Gau-thier commented 2 years ago

Because of an issue with docker on my local environment, I am not able to fully run the tests. Can you check on your side @AlexeyRaga?

Closes https://github.com/haskell-works/hw-kafka-client/issues/182

AlexeyRaga commented 2 years ago

Actually, I don't use Nix build and don't want to maintain it. I am thinking of dropping it in favour of a simple shell.nix that adds librdkafka. This stuff is getting more and more complicated, which I don't think is necessary.

Gau-thier commented 2 years ago

Actually, I don't use Nix build and don't want to maintain it.

Totally understood and agreed that 😉

I am thinking of dropping it in favour of a simple shell.nix that adds librdkafka. This stuff is getting more and more complicated, which I don't think is necessary.

In the current state, this is already what you provide: a "simple" nix-shell. I switched to the unstable branch, to avoid a 6 months delay between "new version is available on unstable and new version will be available in next release". And niv allow you to run niv update without doing any action (files sources.nix and sources.json are generated and managed by niv you don't have to do anything).

From my point of view, if you add a nix-shell you better provide all the necessary binaries (stack, docker, docker-compose, niv, librdkafka) in order to ease contributing. How confortable it is to simply run cd hw-kafka-client and know you are ready to contribute?