search

haskell / ThreadScope

A graphical tool for profiling parallel Haskell programs
http://www.haskell.org/haskellwiki/ThreadScope
Other
154 stars 36 forks source link

Update ghc-events to 0.13.0 #107

Closed maoe closed 4 years ago

maoe commented 4 years ago

As of ghc-events#55 most of the String fields in EventInfo have been replaced with Text. This patch updates threadscope code accordingly. This is incompatible with older ghc-events.

maoe commented 4 years ago

This PR is ready for review now. Could anyone review it, maybe @Mikolaj?

maoe commented 4 years ago

Thanks!

It’s essential not from performance standpoint but rather from the recent change in the API of ghc-events. See https://github.com/haskell/ghc-events/pull/55.

Mikolaj commented 4 years ago

I meant the usage of text builders as opposed to ordinary texts. As in https://hackage.haskell.org/package/text-1.2.4.0/docs/Data-Text-Lazy-Builder.html

Mikolaj commented 4 years ago

Oh, I see now, text builders are used in ghc-events as well. Fine, whatever. And I even reviewed that in ghc-events. :)

maoe commented 4 years ago

Yes, buildEventInfo for example is from ghc-events.

I'll merge this and cut a new release. Thanks for reviewing this.