search

haskell / actions

Github actions for Haskell CI
147 stars 54 forks source link

Determine `outputs.stack-root` via `stack path --stack-root` #215

Closed andreasabel closed 1 year ago

andreasabel commented 1 year ago

https://github.com/haskell/actions/blob/d5d2a76987b2c37320eef82ccc8509ea64c4ff44/setup/README.md?plain=1#L127 It might be simpler and more robust to determine outputs.stack-root via stack path --stack-root. Currently: https://github.com/haskell/actions/blob/d5d2a76987b2c37320eef82ccc8509ea64c4ff44/setup/src/installer.ts#L28-L34

sgadkar2 commented 1 year ago

hi @andreasabel , I am new to open source contribution. Can you please assign this issue to me.

andreasabel commented 1 year ago

Ok, @sgadkar2 , I assigned it to you. PR welcome!

sgadkar2 commented 1 year ago

@andreasabel I have raised a pull request. Can you please check if it is correct.

andreasabel commented 1 year ago

So after investigation in PR #230 it was agreed not to implement the change suggested in this issue.