search

haskell / actions

Github actions for Haskell CI
147 stars 54 forks source link

hlint-run has build failures with typescript 5.0 #227

Closed andreasabel closed 1 year ago

andreasabel commented 1 year ago

With typescript 5.0, hlint-run has build failures at these locations:

https://github.com/haskell/actions/actions/runs/4581184122/jobs/8090527193?pr=223#step:5:7

Error: src/run.ts(48,39): error TS2365: Operator '>' cannot be applied to types 'string | number' and 'number'. Error: src/run.ts(62,41): error TS2365: Operator '>' cannot be applied to types 'string | number' and 'number'.

Originally posted by @andreasabel in https://github.com/haskell/actions/issues/223#issuecomment-1492859183

andreasabel commented 1 year ago

@rwe : Are you willing to maintain the hlint actions here until they have found a new home?

Or should we discontinue them here and point folks back to your repo?

CC @Anton-Latukha .

ulysses4ever commented 1 year ago

@andreasabel could you explain how to repro it locally?

andreasabel commented 1 year ago

@andreasabel could you explain how to repro it locally?

Haven't tried to do so.
(And won't try myself, as I am not maintaining the hlint-actions.)

ulysses4ever commented 1 year ago

Oh, I'm sorry. And i didn't notice the link to the workflow run: that's enough to repro.

ulysses4ever commented 1 year ago

Submitted a fix in https://github.com/haskell/actions/pull/252