Added test for checking stack-root output

haskell / actions

Github actions for Haskell CI

147 stars 54 forks source link

Added test for checking stack-root output #231

Closed sgadkar2 closed 1 year ago

andreasabel commented 1 year ago

Thanks! This had two problems:

steps.setup was undefined because the setup step was not named in this job. I recommend using actionlint to find such problems before shipping.
stack installed a GHC. This can be avoided (I hope) by passing --system-ghc. We might have to take this into account for #230.

I pushed a commit hopefully fixing this.

andreasabel commented 1 year ago

On windows, we still have a problem with backslashes: https://github.com/haskell/actions/actions/runs/4623203883/jobs/8176768081#step:5:96

Returned stack-root: C:sr
Expected stack-root: C:\sr

andreasabel commented 1 year ago

Ok, works now!

sgadkar2 commented 1 year ago

Great. Thanks for your help.

andreasabel commented 1 year ago

Pushed as 87b3442d9877a4ab61f04a4e3d0da2e14be5d51e to main.

I preserved the original commits here so it can be reconstructed what works in CI and what doesn't. (You said you are new to OSS, so maybe it is good learning material.)

Thanks for this test!

andreasabel commented 1 year ago

@sgadkar2 : It would be nice if the test was extended to check that ${STACK_ROOT}, if set, is also the same as outputs.stack-root and $(stack path --stack-root).