haskell / actions

Github actions for Haskell CI
146 stars 54 forks source link

`haskell/actions/hlint-run` doesn't detect `.hlint.yaml` file in working directory #277

Closed benrbray closed 11 months ago

benrbray commented 1 year ago

Question

Does the hlint-run action currently support .hlint.yaml files? If so, what is the recommended way to pass the .hlint.yaml file to the action?

Details

I have the following project structure:

/
├─ .github/
│  ├─ workflows/
│  │  ├─ hlint.yaml
├─ project/
│  ├─ src/
│  ├─ project.cabal
│  ├─ .hlint.yml

Here is .hlint.yaml:

- ignore: {name: Redundant bracket}

Here is (the relevant part of) .github/workflows/hlint.yaml:

name: build
on:
  push:
    branches: [main]
  pull_request:
    branches: [main]

permissions:
  contents: read

jobs:  
  hlint:
    runs-on: ubuntu-latest
    defaults:
      run:
        working-directory: project
    steps:
    - uses: actions/checkout@v3

    - name: 'Set up HLint'
      uses: haskell/actions/hlint-setup@v2

    - name: 'Run HLint'
      uses: haskell/actions/hlint-run@v2
      with:
        path: .
        fail-on: never

In CI, the hlint-run action is successful, but I still get a "redundant bracket" warning. Locally, running hlint automatically detects the .hlint.yaml file and suppresses the warning.

andreasabel commented 1 year ago

@mihaimaruseac : Could you have a look?
Is your offer to maintain the hlint actions still standing?

mihaimaruseac commented 1 year ago

Missed the notification. Will take a look

mihaimaruseac commented 11 months ago

This now should be moved to https://github.com/haskell-actions/hlint-run after the split?

andreasabel commented 11 months ago

Github does not seem to support transfering issues between organizations: https://github.com/orgs/community/discussions/5766

@benrbray Could you please clone this issue to github.com/haskell-actions/hlint-run ?

benrbray commented 11 months ago

Sure, I cloned the issue and will close this one.