search

haskell / actions

Github actions for Haskell CI
147 stars 54 forks source link

Use ghcup to install cabal head #290

Closed nlander closed 1 year ago

nlander commented 1 year ago

This allows head to be the specified cabal version.

andreasabel commented 1 year ago

Thanks.

To evaluate the PR, please add a test to .github/workflows. Once you are happy, please document the new feature in setup/README.

nlander commented 1 year ago

@andreasabel I have added a test and updated the README. I haven't run the test locally, because as far as I can tell it isn't part of the push hook. Please let me know if there is more I can do to help get this merged. Thanks!

nlander commented 1 year ago

@andreasabel I'm hoping these last two commits have fixed the test.

nlander commented 1 year ago

@andreasabel please take another look at this when you have a moment. Is there anything else you think this needs before merging?

ulysses4ever commented 1 year ago

@andreasabel indeed, cabal team would be delighted to have this feature merged.

@nlander thanks a lot for taking the time to prepare the patch!

andreasabel commented 1 year ago

Thanks, I merged it here.

The commit 77e8db13129474e08c7c1ea3887d12491cc60cf2 needs to be transfered to haskell-actions/setup still.

andreasabel commented 1 year ago

I now opened this as a PR at the new home of the setup action: