Merge common code between ALEX_MONAD and ALEX_MONAD_BYTESTRING

haskell / alex

A lexical analyser generator for Haskell

https://hackage.haskell.org/package/alex

BSD 3-Clause "New" or "Revised" License

297 stars 82 forks source link

Merge common code between ALEX_MONAD and ALEX_MONAD_BYTESTRING #134

Closed josephcsible closed 5 years ago

simonmar commented 5 years ago

This looks ok, but could you rebase and update the PR now that I've fixed the CI failure?

josephcsible commented 5 years ago

Done.

hvr commented 5 years ago

@simonmar given in the past seemingly harmless changes to the templates turned out to break consumers of the generated alex parsers; please let's very careful in testing this before so we don't have to schedule in overtime hours for Hackage Trustees to fixup up versions bounds of build-tool-depends all over hackage :-)

simonmar commented 5 years ago

@hvr thanks for the heads up. I wasn't aware of the previous problems. What kind of testing would be appropriate?