search

haskell / alex

A lexical analyser generator for Haskell
https://hackage.haskell.org/package/alex
BSD 3-Clause "New" or "Revised" License
298 stars 82 forks source link

spelling of `DFS.GForrest` #212

Closed ghost closed 2 years ago

ghost commented 2 years ago

What is the basis of this spelling?

$ grep -r Forrest hoopl
hoopl/src/Compiler/Hoopl/MkGraph.hs:     -- Forrest Baskett's while-loop layout
hoopl/src/Compiler/Hoopl/Graph.hs:-- emitting instructions, except that it will not usually exploit Forrest
$ grep -r Forrest alex
alex/src/DFS.hs:-- `GForrest'.  `post_order' provides a post-order traversal of a forrest.
alex/src/DFS.hs:type GForrest = [GTree]
alex/src/DFS.hs:data GTree    = GNode Int GForrest
alex/src/DFS.hs:postorder:: GForrest -> [Int]
alex/src/DFS.hs:scc:: Graph -> GForrest
alex/src/DFS.hs:dff:: Graph -> GForrest
alex/src/DFS.hs:dff':: [Int] -> Graph -> GForrest
alex/src/DFS.hs:prune:: GForrest -> GForrest
alex/src/DFS.hs:chop:: (Set Int,GForrest) -> (Set Int,GForrest)
$

Corrections in the hoopl comments were merged Mar 18, 2022.

andreasabel commented 2 years ago

What is the basis of this spelling?

ghost commented 2 years ago

would it break code to change to GForest

andreasabel commented 2 years ago

would it break code to change to GForest

I think it wouldn't, since alex is an executable only and does not export an API. But also, there are no strong reasons to correct the misspelling, are there? (These lines mostly haven't been touched in 19 years, so we should have some respect ... :-D)