Closed alexbiehl closed 1 year ago
~Hm, tests do pass locally, not sure what's causing the issue.~
(As you already noticed) text
is only a GHC-shipped package from 8.4 on, compare the release notes:
Adding a dependency like text
might require to cabalize the testsuite first. (It's Makefile
design is ancient, probably predating cabal.)
@andreasabel It looks like to fully cabalize the test suite is a long term effort, how about I disable the text specific tests on old GHCs?
how about I disable the text specific tests on old GHCs?
Yes, that seems fair, especially since you add a new feature so it is less important to test it with old GHCs.
Cool! Squash is fine.
I now tested this PR locally by porting one of my projects to the new posn-strict-text
wrapper. Worked!
A new major version (3.4.0.0) looks more appropriate for a new feature, one can then have build-tool-depends: alex:alex >= 3.4
(rather than 3.3.1
).
This PR introduces the strict-text and posn-strict-text wrappers to allows working with Data.Text out of the box.
Implementation wise we could do a bit better by using Data.Text.Foreign.takeWord8 and avoiding the intermediate list of bytes in a codepoint but this will do for now.