Fix all warnings in generated code - Githubissues

haskell / alex

A lexical analyser generator for Haskell

https://hackage.haskell.org/package/alex

BSD 3-Clause "New" or "Revised" License

297 stars 82 forks source link

Fix all warnings in generated code #69

Closed thomie closed 9 years ago

thomie commented 9 years ago

Well... almost. -fno-warn-unused-binds and -fno-warn-missing-signatures are still needed. But we don't need -w. As I mentioned in [1], I think -w is a bad default, as it hides bugs in user code.

Requires a major version upgrade for the removal of iUnbox, and for not importing Data.Char (ord) in the generated code.

[1] https://github.com/simonmar/alex/commit/1eefcde22ba1bb9b51d523814415714e20f0761e#commitcomment-12002704

simonmar commented 9 years ago

Thanks!