Do not swallow newline when parsing comments

haskell / c2hs

c2hs is a pre-processor for Haskell FFI bindings to C libraries

http://hackage.haskell.org/package/c2hs

Other

198 stars 50 forks source link

Do not swallow newline when parsing comments #110

Closed sivertb closed 10 years ago

sivertb commented 10 years ago

The lexer processed the trailing newline following a comment as part of the comment, but did not update the token position to reflect this. This caused the generated LINE pragmas following function argument comments to be wrong. This again seemed to cause Haddock some headache, resulting in misplaced function descriptions

sivertb commented 10 years ago

I'm afraid I found another Haddock issue.

ian-ross commented 10 years ago

@sivertb That's OK! This was a recent change, and it's not so surprising that it might have some teething problems. Thanks for the PRs!