haskell / c2hs

c2hs is a pre-processor for Haskell FFI bindings to C libraries
http://hackage.haskell.org/package/c2hs
Other
199 stars 50 forks source link

Fix C compiler lookup for relocatable GHC #203

Closed KaneTW closed 6 years ago

KaneTW commented 6 years ago

This fixes build on Windows.

Additionally, add some rudimentary Windows CI via Appveyor and bump to 0.28.4

KaneTW commented 6 years ago

New version is up. Now handles spaces in names correctly, and adds ".exe" on windows when removing the executable (might want to change it to a temporary directory for easier cleanup?)

deech commented 6 years ago

Thank you very much for all this work! Would you mind squashing the commits? I'll review it this weekend.

KaneTW commented 6 years ago

Yeah, I'll do it in a sec.

deech commented 6 years ago

Wow, I didn't get a notification that you had squashed the PR. Merging now. Will cut a new release in the next couple of days. Thanks!