haskell / cabal

Official upstream development repository for Cabal and cabal-install
https://haskell.org/cabal
Other
1.61k stars 690 forks source link

External command system missing from 3.12.1.0 release notes #10164

Open hasufell opened 2 months ago

hasufell commented 2 months ago

https://github.com/haskell/cabal/pull/9063/commits/b27fd21d17c229fb8b4bc6a6fef0f79207b90dce

https://github.com/haskell/cabal/blob/master/release-notes/cabal-install-3.12.1.0.md

ffaf1 commented 2 months ago

This is because #9063 was merged without a changelog.d file.

We can of course modify the release notes, but I wonder if this warrants more exposure.

geekosaur commented 2 months ago

I was under the impression this feature is still somewhat experimental, and its further evolution depends on what early adopters find they would benefit from. So it could go either way but probably the balance weighs toward encouraging said early adopters.

Mikolaj commented 2 months ago

It's already documented in the rtd manual, so it's not hidden anyway.

andreabedini commented 2 months ago

@hasufell Let me understand, what if your expectation w.r.t. to fixing this issue? The cabal-install-3.12.1.0 tarball is out and cannot be changed. Do you think making a changelog entry for 3.12.2.0 is a good solution? Thanks.

hasufell commented 2 months ago

You can fix it in:

Not sure how many people care about the tarball.

geekosaur commented 2 months ago

We've already retroactively edited release notes: https://github.com/haskell/cabal/pull/10134 I also note that we (deliberately) point people to the changelog files in master in preference to pregenerated files, e.g. on Hackage. In fact, I think the files in the tarball just point you to https://github.com/haskell/cabal/blob/master/Cabal/ChangeLog.md and https://github.com/haskell/cabal/blob/master/cabal-install/changelog.

hasufell commented 2 months ago

If there's nothing to be done, then feel free to close.