haskell / containers

Assorted concrete container types
https://hackage.haskell.org/package/containers
314 stars 177 forks source link

Fix Issue 1004: effect order in filterAMissing #1005

Closed j6carey closed 1 month ago

j6carey commented 1 month ago

The order of Applicative effects in filterAMissing was incorrect, causing the order of effects to differ from key order and be influenced by how the binary tree was balanced.

The fix is to arrange that effects arising from the key and value at an internal node come after those in its left branch instead of before. (Regardless of this fix such effects come before those effects arising from the right branch.)

This change also expands test coverage to detect a regression of this fix.

j6carey commented 1 month ago

Since I lack permission to initiate a continuous integration workflow or assign a reviewer, would someone be so kind as to trigger those steps?

treeowl commented 1 month ago

Sorry I missed this.

treeowl commented 1 month ago

Thanks!

j6carey commented 1 month ago

Thanks for the CI and merge!